Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@147 PS1, Line 147: #define ASSERT_TOOL_OK(tool_cmd) do { \ : const vector<string>& _args = (tool_cmd); \ > Another way might be using variadic macros: That works! Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07 Gerrit-Change-Number: 11411 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 11 Sep 2018 00:05:46 +0000 Gerrit-HasComments: Yes
