Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 )
Change subject: [WIP] Add helper macro for tool invocations ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11411/1/src/kudu/tools/kudu-admin-test.cc@142 PS1, Line 142: // Note the type specifier and extra parentheses. Unfortunately, these are : // necessary for the macro to parse correctly. Would you still need that if tool_cmd was embedded in the call to RunKuduTool rather than evaluated up-front? -- To view, visit http://gerrit.cloudera.org:8080/11411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07 Gerrit-Change-Number: 11411 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 10 Sep 2018 20:31:07 +0000 Gerrit-HasComments: Yes
