Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11457
to review the following change.
Change subject: clang_tidy_gerrit.py: fix output when no changes found in first
path
......................................................................
clang_tidy_gerrit.py: fix output when no changes found in first path
I was perplexed as to why some patches weren't getting any clang-tidy
comments, so I went looking at the clang-tidy job output and found this:
Clang output
No relevant changes found.
No relevant changes found.
... <actual clang-tidy changes>
Traceback (most recent call last):
File "build-support/clang_tidy_gerrit.py", line 209, in <module>
parsed = parse_clang_output(clang_output)
File "build-support/clang_tidy_gerrit.py", line 103, in parse_clang_output
raise Exception("bad warning: " + w)
Exception: bad warning: No relevant changes found.
No relevant changes found.
Turns out that although clang_tidy_gerrit.py never handled "No relevant..."
properly, commit a9271b05d significantly increased the chances that the very
first line of output would be this string. That's a necessary condition for
split_warnings() to generate a warning starting with a non-warning string,
which led to the exception and no posted comments.
Change-Id: I111dff7508f841489ba1625a4ca4b7af92f3d8d0
---
M build-support/clang_tidy_gerrit.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11457/1
--
To view, visit http://gerrit.cloudera.org:8080/11457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I111dff7508f841489ba1625a4ca4b7af92f3d8d0
Gerrit-Change-Number: 11457
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
