Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11457 )

Change subject: clang_tidy_gerrit.py: fix output when no changes found in first 
path
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

> Patch Set 2:
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/11457/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11457/1//COMMIT_MSG@12
PS1, Line 12: what I saw in the console output of one such failed job run:
            :
            :   Clang output
            :   No relevant changes found.
            :   No relevant changes found.
            :   ... <actual clang-tidy changes>
            :   Traceback (most recent call last):
            :     File "build-support/clang_tidy_gerrit.py", line 209, in 
<module>
            :       parsed = parse_clang_output(clang_output)
            :     File "build-support/clang_tidy_gerrit.py", line 103, in 
parse_clang_output
            :       raise Exception("bad w
> "No relevant..." is what clang-tidy returns when it has nothing to recommen
Got it. Thanks for the explanation (and the update)!



--
To view, visit http://gerrit.cloudera.org:8080/11457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111dff7508f841489ba1625a4ca4b7af92f3d8d0
Gerrit-Change-Number: 11457
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 18 Sep 2018 18:26:08 +0000
Gerrit-HasComments: Yes

Reply via email to