Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11457 )
Change subject: clang_tidy_gerrit.py: fix output when no changes found in first path ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11457/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11457/1//COMMIT_MSG@12 PS1, Line 12: what I saw in the console output of one such failed job run: : : Clang output : No relevant changes found. : No relevant changes found. : ... <actual clang-tidy changes> : Traceback (most recent call last): : File "build-support/clang_tidy_gerrit.py", line 209, in <module> : parsed = parse_clang_output(clang_output) : File "build-support/clang_tidy_gerrit.py", line 103, in parse_clang_output : raise Exception("bad w > Without digging into the clang tidy script, I'm not sure why certain patche "No relevant..." is what clang-tidy returns when it has nothing to recommend. That's very unlikely when run on an entire patch (as we used to do), but after commit a9271b05d, we actually run it once per changed file, so now it's possible to see it as some files (especially new ones) are completely tidy. To trigger the bug, you need the _very first_ file processed to produce this message, at which point split_warnings() gets messed up and returns a warning containing just the "No relevant..." line, which causes parse_clang_output() to raise an exception, the script to abort, and no clang-tidy comments to materialize in the gerrit. -- To view, visit http://gerrit.cloudera.org:8080/11457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I111dff7508f841489ba1625a4ca4b7af92f3d8d0 Gerrit-Change-Number: 11457 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 18 Sep 2018 17:18:20 +0000 Gerrit-HasComments: Yes
