Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11449 )
Change subject: KUDU-2580 [c++ client] authn token reacquisition fix ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11449/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/11449/2/src/kudu/client/client-internal.h@191 PS2, Line 191: // A dedicated enumeration for the third parameter of the ReconnectToCluster() : // method below. : enum class ReconnectionReason { : INVALID_AUTHN_TOKEN, : OTHER, : }; > Nit: The following formatting would suffice: Done http://gerrit.cloudera.org:8080/#/c/11449/2/src/kudu/client/client-internal.h@203 PS2, Line 203: Log any failures with LOG(WARNING) with a limit of 1 log : // message per second. > This detail can be elided. Done http://gerrit.cloudera.org:8080/#/c/11449/1/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/11449/1/src/kudu/client/client-internal.cc@659 PS1, Line 659: urity::Cert cert; > If the goal is to produce an easily backportable patch, I'd recommend dropp Done -- To view, visit http://gerrit.cloudera.org:8080/11449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4477d0f2bb36ee5ef580b585cae189a634d5002f Gerrit-Change-Number: 11449 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 19 Sep 2018 19:14:04 +0000 Gerrit-HasComments: Yes
