Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11449 )
Change subject: KUDU-2580 [c++ client] authn token reacquisition fix ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/client/client-internal.cc@204 PS3, Line 204: if (err && err->has_code() && > If we're being pedantic, you should revert this cleanup. Done http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/client/client-internal.cc@264 PS3, Line 264: // Operation deadline expired during this latest RPC. > Ditto. Done http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/client/client-internal.cc@278 PS3, Line 278: return StatusFromPB(resp->error().status()); > Ditto. Done http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/integration-tests/authn_token_expire-itest.cc File src/kudu/integration-tests/authn_token_expire-itest.cc: http://gerrit.cloudera.org:8080/#/c/11449/3/src/kudu/integration-tests/authn_token_expire-itest.cc@500 PS3, Line 500: builder.default_rpc_timeout(MonoDelta::FromSeconds(5)); > Did you mean to incorporate this change into the first patch, the one that Ah, right -- that should be there, thanks. -- To view, visit http://gerrit.cloudera.org:8080/11449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4477d0f2bb36ee5ef580b585cae189a634d5002f Gerrit-Change-Number: 11449 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 19 Sep 2018 19:44:05 +0000 Gerrit-HasComments: Yes
