Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11449 )
Change subject: KUDU-2580 [c++ client] authn token reacquisition fix ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11449/1/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/11449/1/src/kudu/client/client-internal.cc@270 PS1, Line 270: if (resp->error().code() == MasterErrorPB::NOT_THE_LEADER || > Oh, I thought the aliased error issue was manifesting on the other masters, The way how ConnectToCluster() works now is that it does not purge cached leader master proxy in case of NOT_THE_LEADER error. I think that should be updated -- that's the idea behind the refactoring which I think would be nice to do here: change the behavior of the ConnectToCluster() to purge the cached master leader proxy in case of NOT_THE_LEADER response. At least, semantically that would be a cleaner way to go. -- To view, visit http://gerrit.cloudera.org:8080/11449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4477d0f2bb36ee5ef580b585cae189a634d5002f Gerrit-Change-Number: 11449 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 19 Sep 2018 19:28:33 +0000 Gerrit-HasComments: Yes
