Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11516 )
Change subject: tserver: log a message when a scanner is not found ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc@1268 PS1, Line 1268: StatusToPB(Status::NotFound("Scanner not found"), resp->mutable_error()->mutable_status()); > Does it make sense to add a log message here as well? Nice catch, seems like a good idea. Done. http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc@2015 PS1, Line 2015: Status verbose = s.CloneAndAppend(Substitute("call sequence id=$0, remote=$1", : req->call_seq_id(), : rpc_context->requestor_string())); > Why not to put this information into the returned status as is? The returned Status message will show up in an Impala query error message, and I think dumping excessive information onto the user would be more confusing than helpful. I don't think the verbose message will help most people because it probably wouldn't mean much to anyone who isn't a Kudu technical expert. The scanner id, on the other hand, is greppable so I think it's worth surfacing. http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc@2038 PS1, Line 2038: if (req->call_seq_id() != scanner->call_seq_id()) { : *error_code = TabletServerErrorPB::INVALID_SCAN_CALL_SEQ_ID; : return Status::InvalidArgument("Invalid call sequence ID in scan request"); : } > Some unrelated to this particular change, but maybe relevant stuff when cha These are all great points. I'll follow up on those with a separate change list. -- To view, visit http://gerrit.cloudera.org:8080/11516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90 Gerrit-Change-Number: 11516 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 21:46:24 +0000 Gerrit-HasComments: Yes
