Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11516 )
Change subject: tserver: log a message when a scanner is not found ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11516/1/src/kudu/tserver/tablet_service.cc@2015 PS1, Line 2015: Status verbose = s.CloneAndAppend(Substitute("call sequence id=$0, remote=$1", : req->call_seq_id(), : rpc_context->requestor_string())); > The returned Status message will show up in an Impala query error message, All right, that makes sense to me, thank you for the explanation. BTW, just another nit (feel free to ignore): if the 'verbose' is not referenced elsewhere but while producing the log message, maybe drop the 'verbose' variable and write something like LOG(INFO) << s.CloneAndAppend(Substitute( "call sequence id=$0, remote=$1", req->call_seq_id(), rpc_context->requestor_string())); -- To view, visit http://gerrit.cloudera.org:8080/11516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90 Gerrit-Change-Number: 11516 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 26 Sep 2018 22:39:37 +0000 Gerrit-HasComments: Yes
