Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Grant Henke,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11516

to look at the new patch set (#2).

Change subject: tserver: log a message when a scanner is not found
......................................................................

tserver: log a message when a scanner is not found

Right now there is a class of issues where an "upstream" service or
query engine such as Impala or Spark may not be able to find a Kudu
scanner, resulting in a failed query. Often, this is because the scanner
timed out. The query engine will receive and typically log a message
indicating that the scanner could not be found, however it's difficult
to trace this back to the original query because the client wouldn't
know the scanner id and the server would not log the event.

With this change, it will be much easier to match up query engine
failures with expiring scanners by looking at the logs on both sides
because when a request comes in for a scanner that cannot be found, the
client will get a bad status like so:

  Not found: Scanner f87cc39d55d24c52bcf547f211e46b8b not found (it may have 
expired)

And the server will log a slightly more verbose message like:

  I0925 15:29:38.875579 22293 tablet_service.cc:2017] Not found: Scanner 
f87cc39d55d24c52bcf547f211e46b8b not found  (it may have expired): call 
sequence id=1, remote={username='mpercy'} at 127.0.0.1:57118

Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90
---
M src/kudu/client/client-test.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
4 files changed, 47 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11516/2
--
To view, visit http://gerrit.cloudera.org:8080/11516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4e9c69160605d4a839ac2d28def67f4d3402b90
Gerrit-Change-Number: 11516
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot

Reply via email to