Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11593
to look at the new patch set (#2).
Change subject: C++11 improvements to Schema
......................................................................
C++11 improvements to Schema
This adds a move constructor and move assignment operator to Schema.
I removed Schema::swap. It was only used in tests, and any potential
use of it should be adequately fulfilled by one of moves, copies, or
Schema::Reset.
I also replaced a couple of unnecessarily verbose constructors with
single-argument ones, which is possible because of the addition of
single-argument Allocator constructors for std::unordered_map in C++11.
Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
3 files changed, 106 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/11593/2
--
To view, visit http://gerrit.cloudera.org:8080/11593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2
Gerrit-Change-Number: 11593
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
