Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11593 )
Change subject: Move constructor and assignment operator for Schema ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11593/4/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/11593/4/src/kudu/common/schema.h@403 PS4, Line 403: semantic Nit: semantics http://gerrit.cloudera.org:8080/#/c/11593/4/src/kudu/common/schema.h@415 PS4, Line 415: i Nit: drop the extra 'i'. Below too. BTW, you could convert the TODO into a "well, C++11 does provide a nicer constructor, but that's not implemented in gcc 4.8 [pick more precise version range], so until we drop support for that compiler, we can't use it". It might be worth doing because we can fix this if we adopt C++14 or C++17, which isn't supported by gcc 4.8. http://gerrit.cloudera.org:8080/#/c/11593/4/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/11593/4/src/kudu/common/schema.cc@191 PS4, Line 191: allocator* Nit: I'd use "allocator[1]" for the footnote; the asterisk suggests a pointer type in this context. -- To view, visit http://gerrit.cloudera.org:8080/11593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2 Gerrit-Change-Number: 11593 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 05 Oct 2018 08:17:12 +0000 Gerrit-HasComments: Yes
