Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11593 )
Change subject: Move constructor and assignment operator for Schema ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.h@459 PS5, Line 459: name_to_index_(/*bucket_counti=*/10, > Nit: bucket_counti here too. Done -- To view, visit http://gerrit.cloudera.org:8080/11593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2 Gerrit-Change-Number: 11593 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 05 Oct 2018 17:56:19 +0000 Gerrit-HasComments: Yes
