Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11593 )
Change subject: Move constructor and assignment operator for Schema ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.h@908 PS5, Line 908: move > nit: that applies to the copy constructor as well isn't it? Both copy-assign and copy-construct are implemented in terms of CopyFrom. http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/11593/5/src/kudu/common/schema.cc@191 PS5, Line 191: which will mean the moved : // to value will be holding a pointer to the moved-from's member > Would it help to allocate the name_to_index_bytes_ on the heap (probably, w Seems unnecessary. This works, and the type is trivially copyable. Involving the heap makes Schema slower. -- To view, visit http://gerrit.cloudera.org:8080/11593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c827c84657875be4cf2bc565db03a686849d8e2 Gerrit-Change-Number: 11593 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 05 Oct 2018 18:22:52 +0000 Gerrit-HasComments: Yes
