Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11570 )
Change subject: Extract connection retrying and HA support from HmsCatalog ...................................................................... Extract connection retrying and HA support from HmsCatalog Introduces a new abstraction, thrift::HaClient, for providing HA and retrying support on top of Thrift clients like HmsClient and SentryClient. The implementation is extracted from HmsCatalog, and is not changed in any significant ways. The implementation is inlined into a header because the class requires a template parameter (to choose between HmsClient or SentryClient), and forward declaring these instantiations is not possible because the thrift module does not link to the hms or sentry modules. No tests are provided for HaClient in isolation, instead it's tested through existing and new failover tests of HaClient<HmsClient> and HaClient<SentryClient>. This patch should have little or no functional changes. Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Reviewed-on: http://gerrit.cloudera.org:8080/11570 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/hms/hms_catalog.cc M src/kudu/hms/hms_catalog.h M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/sentry/sentry_client-test.cc M src/kudu/sentry/sentry_client.cc M src/kudu/sentry/sentry_client.h M src/kudu/thrift/client.cc M src/kudu/thrift/client.h 9 files changed, 343 insertions(+), 247 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Gerrit-Change-Number: 11570 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
