Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11570 )
Change subject: Extract connection retrying and HA support from HmsCatalog ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11570/3/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/11570/3/src/kudu/sentry/sentry_client-test.cc@50 PS3, Line 50: TEST_F(SentryClientTest, TestMiniSentryLifecycle) { > Er, I think you did mean TEST_P here. It wasn't actually enabling Kerberos, so it was getting run twice for no reason. I could change it to enable Kerberos, but I don't think it would meaningfully add coverage over the existing coverage in TestCreateDropRole. -- To view, visit http://gerrit.cloudera.org:8080/11570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Gerrit-Change-Number: 11570 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 05 Oct 2018 18:56:57 +0000 Gerrit-HasComments: Yes
