Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11570 )
Change subject: Extract connection retrying and HA support from HmsCatalog ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/hms/hms_catalog.cc@276 PS2, Line 276: Slice hms_database; : Slice hms_table; : RETURN_NOT_OK(ParseTableName(name, &hms_database, &hms_table)); Could be lifted out of the Execute() call. http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/thrift/client.h File src/kudu/thrift/client.h: http://gerrit.cloudera.org:8080/#/c/11570/2/src/kudu/thrift/client.h@186 PS2, Line 186: // TODO(todd): wrapping this in a TRACE_EVENT scope and a LOG_IF_SLOW and such : // would be helpful. Perhaps a TRACE message and/or a TRACE_COUNTER_INCREMENT : // too to keep track of how much time is spent in calls to HMS for a given : // CreateTable call. That will also require propagating the current Trace : // object into the 'Rpc' object. Note that the HmsClient class already has : // LOG_IF_SLOW calls internally. Should be updated to remove HMS references. -- To view, visit http://gerrit.cloudera.org:8080/11570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8135f4c3995bba0ba28384c35696a1771ff5296 Gerrit-Change-Number: 11570 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 03 Oct 2018 16:00:46 +0000 Gerrit-HasComments: Yes
