Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11606 )
Change subject: [tests] location assignment for ExternaMiniCluster ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/integration-tests/ts_location_assignment-itest.cc File src/kudu/integration-tests/ts_location_assignment-itest.cc: http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/integration-tests/ts_location_assignment-itest.cc@39 PS2, Line 39: using kudu::cluster::ExternalTabletServer; > warning: using decl 'ExternalTabletServer' is unused [misc-unused-using-dec Done http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/integration-tests/ts_location_assignment-itest.cc@74 PS2, Line 74: EmplaceOrDie(&info, std::move(location), 1); > warning: std::move of the const variable 'location' has no effect; remove s Done http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/integration-tests/ts_location_assignment-itest.cc@81 PS2, Line 81: EmplaceOrDie(&info, std::move(location), num); > warning: std::move of the const variable 'location' has no effect; remove s Done http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11606/2/src/kudu/master/ts_descriptor.cc@71 PS2, Line 71: using std::make_shared; > warning: using decl 'make_shared' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/11606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63309804cf2fdd8a620b50abdd7133af6a033c30 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 16:55:24 +0000 Gerrit-HasComments: Yes
