Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11606 )
Change subject: [tests] location assignment for ExternaMiniCluster ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/mini-cluster/external_mini_cluster.h@168 PS3, Line 168: form Extra "form". http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/mini-cluster/external_mini_cluster.cc@386 PS3, Line 386: auto location_cmd = Substitute("$0 --state_store=$1", : mapping_script_path, state_store_fpath); I think this wouldn't work in a multimaster setup, since the masters will share a state store and race registering tablet servers. It's a quirk of how we have all TS register with all masters. Ideally we'd give each master its own state store, but I think it'd suffice to check that the EMC location assignment feature is only used with a single master. -- To view, visit http://gerrit.cloudera.org:8080/11606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63309804cf2fdd8a620b50abdd7133af6a033c30 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 17:59:12 +0000 Gerrit-HasComments: Yes
