Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11606 )
Change subject: [tests] location assignment for ExternaMiniCluster ...................................................................... Patch Set 3: (2 comments) Looks good! 2 little things. http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/integration-tests/scripts/assign-location.py File src/kudu/integration-tests/scripts/assign-location.py: http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/integration-tests/scripts/assign-location.py@57 PS3, Line 57: 127.0.0.1 nit: I think you meant 1.2.3.4. http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/integration-tests/ts_location_assignment-itest.cc File src/kudu/integration-tests/ts_location_assignment-itest.cc: http://gerrit.cloudera.org:8080/#/c/11606/3/src/kudu/integration-tests/ts_location_assignment-itest.cc@49 PS3, Line 49: // public ExternalMiniClusterITestBase Why is this commented out? -- To view, visit http://gerrit.cloudera.org:8080/11606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63309804cf2fdd8a620b50abdd7133af6a033c30 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 08 Oct 2018 18:58:14 +0000 Gerrit-HasComments: Yes
