Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0 ...................................................................... Patch Set 5: (13 comments) Mostly just a bunch of backtick nits. Might be worth rendering it in Github or Jekyll to make sure it looks alright. http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@41 PS5, Line 41: nit: extra space http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@106 PS5, Line 106: nit: extra space http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@111 PS5, Line 111: is about nit: "accomplishes the following:"? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@138 PS5, Line 138: getpwuid_r() nit: add backticks http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@161 PS5, Line 161: ) looks like an extra parens http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@174 PS5, Line 174: ksck nit: backticks? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@182 PS5, Line 182: /mem-trackers nit: backticks http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@197 PS5, Line 197: KuduTableInputFormat nit: backticks http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@208 PS5, Line 208: FATAL nit: backticks? or just remove http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@212 PS5, Line 212: `use-after-free` maybe no backticks? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224 PS5, Line 224: tabllets tablets http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@227 PS5, Line 227: Fixed logging init if linking kudu client library: prior to this fix, the kudu CLI tool : would unexpectedly exit on SIGPIPE when master/tserver abruptly closed connection. Maybe reword: "Fixed an error that would cause the Kudu CLI tool to unexpectedly exit when the connection to the master or tserver was abruptly closed." At first I thought this was just a logging error, but I don't think it was? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@228 PS5, Line 228: SIGPIPE nit: backticks -- To view, visit http://gerrit.cloudera.org:8080/11647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837 Gerrit-Change-Number: 11647 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Piros <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Ferenc Szabo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 10 Oct 2018 23:32:45 +0000 Gerrit-HasComments: Yes
