Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0 ...................................................................... Patch Set 5: (14 comments) http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40 PS5, Line 40: - Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration is Java 7 : compatible. Flume 1.8 is the default dependency version as of Kudu 1.8.0. this is a little confusing to me, since Kudu itself doesn't have Flume as a dependency. Maybe we should say something like "The Flume sink released with Kudu 1.8.0 is now compiled to build against Flume 1.8 and will not function with earlier versions of Flume. Note that Flume 1.8 requires Java 8 or higher." (I assume the "will not function" part is correct?) That way it's clearer that this only affects people using Flume. http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43 PS5, Line 43: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7 : compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0. similar feedback here, I'm not sure what exactly this means. If I'm using Hadoop 2.x can I no longer use Kudu? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@53 PS5, Line 53: deprecated it appears that this configuration was removed, not deprecated. Deprecated means that it will still work but is being phased out, but I can't find it in the source anymore. http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@58 PS5, Line 58: deprecated it seems these ones really are deprecated and not removed, right? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@63 PS5, Line 63: == New features I would argue that a lot of these new features are more "improvements". Can we move all of the smaller ones here into the improvements section and keep it to 2-3 headline features? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@65 PS5, Line 65: - A great deal of work went into providing examples that showcase Kudu client style nit: i dont think the amount of work spent is relevant in the context of release notes. Better to just state the facts that we imported and improved a set of examples that were previously hosted in a separate repository on github http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@101 PS5, Line 101: Enable nit: Enabled http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@104 PS5, Line 104: - Introduced rebalancer into the kudu CLI tool. The rebalancer can be used to redistribute would say something like "a manual data rebalancer" instead of just "rebalancer" to be more specific. Is there documentation on this that can be linked to? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109 PS5, Line 109: - Replica selection in master honors placement policy. The way how the master places : replicas of new tablets has changed. In essence (for details see : https://s.apache.org/location-awareness-design), the placement policy is about: : : ** in case of N locations, N > 2, not placing the majority of replicas in one location; : : ** spreading replicas evenly among available locations; : : ** within a location, spreading replicas evenly among tablet servers. is the placement policy work actually complete for this release? I thought it was still work-in-progress in terms of making the balancer, ksck, etc aware. I would suggest not including it here if it's not ready for primetime including docs and tool support. http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125 PS5, Line 125: 15 minutes 15 minutes, really? isn't our server side scanner timeout one minute? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@142 PS5, Line 142: - Improved rowset tree pruning (see can this be expanded to indicate what kind of operations might be faster? iirc it improved scans where one endpoint was specified and the other was not or something? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@146 PS5, Line 146: deprecated removed http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@190 PS5, Line 190: deleted nit: comma after 'deletd' http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224 PS5, Line 224: tabllets typo -- To view, visit http://gerrit.cloudera.org:8080/11647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837 Gerrit-Change-Number: 11647 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Piros <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Ferenc Szabo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 10 Oct 2018 23:33:33 +0000 Gerrit-HasComments: Yes
