Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0 ...................................................................... Patch Set 5: (25 comments) http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40 PS5, Line 40: - Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration is Java 7 : compatible. Flume 1.8 is the default dependency version as of Kudu 1.8.0. > this is a little confusing to me, since Kudu itself doesn't have Flume as a @Grant do you know if the "will not function" part is correct? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@41 PS5, Line 41: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43 PS5, Line 43: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7 : compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0. > similar feedback here, I'm not sure what exactly this means. If I'm using H @Grant, do you have any extra context here? http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@53 PS5, Line 53: deprecated > it appears that this configuration was removed, not deprecated. Deprecated Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@58 PS5, Line 58: deprecated > it seems these ones really are deprecated and not removed, right? yep, seems like these are really deprecated only @Deprecated public static final String SKIP_MISSING_COLUMN_PROP = "skipMissingColumn"; @Deprecated public static final boolean DEFAULT_SKIP_MISSING_COLUMN = false; @Deprecated public static final String SKIP_BAD_COLUMN_VALUE_PROP = "skipBadColumnValue"; @Deprecated public static final boolean DEFAULT_SKIP_BAD_COLUMN_VALUE = false; @Deprecated public static final String WARN_UNMATCHED_ROWS_PROP = "skipUnmatchedRows"; @Deprecated public static final boolean DEFAULT_WARN_UNMATCHED_ROWS = true; http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@65 PS5, Line 65: - A great deal of work went into providing examples that showcase Kudu client > style nit: i dont think the amount of work spent is relevant in the context Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@101 PS5, Line 101: Enable > nit: Enabled Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@104 PS5, Line 104: - Introduced rebalancer into the kudu CLI tool. The rebalancer can be used to redistribute > would say something like "a manual data rebalancer" instead of just "rebala Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@106 PS5, Line 106: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@111 PS5, Line 111: is about > nit: "accomplishes the following:"? Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109 PS5, Line 109: - Replica selection in master honors placement policy. The way how the master places : replicas of new tablets has changed. In essence (for details see : https://s.apache.org/location-awareness-design), the placement policy is about: : : ** in case of N locations, N > 2, not placing the majority of replicas in one location; : : ** spreading replicas evenly among available locations; : : ** within a location, spreading replicas evenly among tablet servers. > is the placement policy work actually complete for this release? I thought I'll ask Alexey about this http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125 PS5, Line 125: 15 minutes > 15 minutes, really? isn't our server side scanner timeout one minute? I'll ask Grant about this http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@138 PS5, Line 138: getpwuid_r() > nit: add backticks Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@142 PS5, Line 142: - Improved rowset tree pruning (see > can this be expanded to indicate what kind of operations might be faster? i looking into this http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@146 PS5, Line 146: deprecated > removed Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@161 PS5, Line 161: ) > looks like an extra parens Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@174 PS5, Line 174: ksck > nit: backticks? Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@182 PS5, Line 182: /mem-trackers > nit: backticks Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@190 PS5, Line 190: deleted > nit: comma after 'deletd' Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@197 PS5, Line 197: KuduTableInputFormat > nit: backticks Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@208 PS5, Line 208: FATAL > nit: backticks? or just remove Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@212 PS5, Line 212: `use-after-free` > maybe no backticks? Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224 PS5, Line 224: tabllets > typo Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@228 PS5, Line 228: SIGPIPE > nit: backticks Done http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@227 PS5, Line 227: Fixed logging init if linking kudu client library: prior to this fix, the kudu CLI tool : would unexpectedly exit on SIGPIPE when master/tserver abruptly closed connection. > Maybe reword: "Fixed an error that would cause the Kudu CLI tool to unexpec Done -- To view, visit http://gerrit.cloudera.org:8080/11647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.8.x Gerrit-MessageType: comment Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837 Gerrit-Change-Number: 11647 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Piros <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Ferenc Szabo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Mitch Barnett Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 11 Oct 2018 00:09:27 +0000 Gerrit-HasComments: Yes
