Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "service_name" as part of ConnectionId ...................................................................... Patch Set 1: (3 comments) Thanks for doing this. Just a few comments. http://gerrit.cloudera.org:8080/#/c/11681/1/src/kudu/rpc/connection_id.h File src/kudu/rpc/connection_id.h: http://gerrit.cloudera.org:8080/#/c/11681/1/src/kudu/rpc/connection_id.h@56 PS1, Line 56: // Copy state from another object to this one. : void CopyFrom(const ConnectionId& other); Looks like this isn't implemented. We can consider removing this. http://gerrit.cloudera.org:8080/#/c/11681/1/src/kudu/rpc/connection_id.cc File src/kudu/rpc/connection_id.cc: http://gerrit.cloudera.org:8080/#/c/11681/1/src/kudu/rpc/connection_id.cc@52 PS1, Line 52: string ConnectionId::ToString() const { Need to incorporate service_name_ here too. http://gerrit.cloudera.org:8080/#/c/11681/1/src/kudu/rpc/connection_id.cc@69 PS1, Line 69: boost::hash_combine(seed, user_credentials_.HashCode()); We need to include the service_name_ as part of the HashCode too. -- To view, visit http://gerrit.cloudera.org:8080/11681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6767e631fd9530ea54f5ed63ff4c8c179ab216b2 Gerrit-Change-Number: 11681 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 15 Oct 2018 23:56:59 +0000 Gerrit-HasComments: Yes
