Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "service_name" as part of ConnectionId ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11681/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11681/1//COMMIT_MSG@7 PS1, Line 7: Add "service_name" as part of ConnectionId I think this needs to be a separately-configured option. In Kudu we use lots of separate services and putting them each on their own connection would increase the number of TCP connections pretty substantially (and without reason in many cases) I'd lean towards one of: 1) add a new option on Proxy or RPC controller like '->set_service_plane("foo")' or even 'set_service_plane(kMyIntegerConstant)' ... which passes through to the ConnectionId. Doing it on the Proxy is probably more convenient than doing it per-RPC call, but doing it per-RPC is a bit more flexible as even within a single service we might have some calls which are considered "control messages" (high-priority low data) and others considered data messages. (we have this case in Kudu's Consensus Service where liveness heartbeats can get stuck behind heavy data-bearing requests) 2) add an option to the RPC service itself (annotated via a protobuf service option, similar to the 'default_authz_method' option). The option would set the service plane for the service for all calls. These options retain existing behavior for Kudu but give callers the ability to customize things, and map N services to M connections (where M <= N). In Kudu we'd probably map all of our connections that carry data onto one plane and all connections that carry only control info onto another. Note that I'm using the term "service plane" or "network plane" or somesuch here distinct from service name itself to capture the N-M mapping. -- To view, visit http://gerrit.cloudera.org:8080/11681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6767e631fd9530ea54f5ed63ff4c8c179ab216b2 Gerrit-Change-Number: 11681 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 16 Oct 2018 00:43:02 +0000 Gerrit-HasComments: Yes
