Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11683 )
Change subject: Fix jsonreader signed int extraction and add unsigned extraction ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11683/6/src/kudu/util/jsonreader-test.cc File src/kudu/util/jsonreader-test.cc: http://gerrit.cloudera.org:8080/#/c/11683/6/src/kudu/util/jsonreader-test.cc@139 PS6, Line 139: constexpr auto kMaxInt32 = std::numeric_limits<int32_t>::max(); : constexpr auto kMaxInt64 = std::numeric_limits<int64_t>::max(); : constexpr auto kMaxUint32 = std::numeric_limits<uint32_t>::max(); : constexpr auto kMaxUint64 = std::numeric_limits<uint64_t>::max(); : constexpr auto kMinInt32 = std::numeric_limits<int32_t>::min(); : constexpr auto kMinInt64 = std::numeric_limits<int64_t>::min(); We also have the older definitions in gutil/integral_types.h. Not sure what's considered the best practice at this point. -- To view, visit http://gerrit.cloudera.org:8080/11683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b07757bacc756643aea5613b3491a34cb051a43 Gerrit-Change-Number: 11683 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 03:18:59 +0000 Gerrit-HasComments: Yes
