Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11683 )
Change subject: Fix jsonreader signed int extraction and add unsigned extraction ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/11683/6/src/kudu/util/jsonreader-test.cc File src/kudu/util/jsonreader-test.cc: http://gerrit.cloudera.org:8080/#/c/11683/6/src/kudu/util/jsonreader-test.cc@179 PS6, Line 179: 64const char* const signed_big64 = "signed_big32"; > Delete? Done http://gerrit.cloudera.org:8080/#/c/11683/6/src/kudu/util/jsonreader-test.cc@184 PS6, Line 184: ASSERT_TRUE(r.ExtractUint32(r.root(), signed_big64, nullptr).IsInvalidArgument()); > nit: No check for ExtractInt32()? Done -- To view, visit http://gerrit.cloudera.org:8080/11683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b07757bacc756643aea5613b3491a34cb051a43 Gerrit-Change-Number: 11683 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 16:48:33 +0000 Gerrit-HasComments: Yes
