Will Berkeley has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/11683 )
Change subject: Fix jsonreader signed int extraction and add unsigned extraction
......................................................................
Fix jsonreader signed int extraction and add unsigned extraction
JsonReader::GetInt64's implementation was actually of
JsonReader::GetUint64, and similarly for JsonReader::GetInt. This patch
corrects the error and adds JsonReader::{GetUint32, GetUint64} too.
A new test ensures that the 4 JsonReader::Get[Ui|I]nt[32|64] methods
work as expected on signed and unsigned values.
Change-Id: I0b07757bacc756643aea5613b3491a34cb051a43
Reviewed-on: http://gerrit.cloudera.org:8080/11683
Reviewed-by: Andrew Wong <[email protected]>
Tested-by: Will Berkeley <[email protected]>
---
M src/kudu/util/jsonreader-test.cc
M src/kudu/util/jsonreader.cc
M src/kudu/util/jsonreader.h
3 files changed, 139 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Will Berkeley: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b07757bacc756643aea5613b3491a34cb051a43
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 9
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
