Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 )
Change subject: [sentry] move ParseTableName to table_util ...................................................................... Patch Set 5: Hmm, wish I got here earlier. I don't love the use of common for this; common is Kudu-specific common stuff (wire protocol, schema, row/column block layouts, etc.) and this is squarely a Hive thing. What do you guys think about moving it back to the hms module but making it a header-only inlined function so that consumers need not link against (and thus depend on) the hms module? -- To view, visit http://gerrit.cloudera.org:8080/11658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fff5aaff623ac65a949f6cabebd9eca997f5cdc Gerrit-Change-Number: 11658 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 17 Oct 2018 03:46:09 +0000 Gerrit-HasComments: No
