Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11658 )
Change subject: [sentry] move ParseTableName to table_util ...................................................................... Patch Set 5: (2 comments) > Hmm, wish I got here earlier. I don't love the use of common for > this; common is Kudu-specific common stuff (wire protocol, schema, > row/column block layouts, etc.) and this is squarely a Hive thing. > > What do you guys think about moving it back to the hms module but > making it a header-only inlined function so that consumers need not > link against (and thus depend on) the hms module? I am good to move it back to the hms module, just wondering whether this function is too large to be inlined? http://gerrit.cloudera.org:8080/#/c/11658/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11658/3//COMMIT_MSG@9 PS3, Line 9: , so > nit: use a comma instead Done http://gerrit.cloudera.org:8080/#/c/11658/3/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/11658/3/src/kudu/integration-tests/master_hms-itest.cc@45 PS3, Line 45: #include "kudu/util/status.h" > error: 'kudu/util/table_util.h' file not found [clang-diagnostic-error] Done -- To view, visit http://gerrit.cloudera.org:8080/11658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fff5aaff623ac65a949f6cabebd9eca997f5cdc Gerrit-Change-Number: 11658 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Oct 2018 05:47:11 +0000 Gerrit-HasComments: Yes
