Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11693 )
Change subject: Fix thrift operator< implementations ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11693/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11693/4//COMMIT_MSG@7 PS4, Line 7: Fix thrift operator< implementations > Obviously it's not ideal that thrift works this way, but our hands are tied Oh, so the generated Thrift code already includes (broken) operator< implementations? If not, we could convert these implementations into functors and feed them as comparators into std::map/std::set. It's more annoying but it conforms to the style. -- To view, visit http://gerrit.cloudera.org:8080/11693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aacf602c603b05433c357a4a236ba0b9e521392 Gerrit-Change-Number: 11693 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 17 Oct 2018 20:32:52 +0000 Gerrit-HasComments: Yes
