Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11693 )
Change subject: Fix thrift operator< implementations ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11693/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11693/4//COMMIT_MSG@7 PS4, Line 7: Fix thrift operator< implementations > Oh, so the generated Thrift code already includes (broken) operator< implem No, Thrift generated operator< declarations, but not definitions. The std::map/set instances are created by thrift, so we don't have the ability to change the constructor calls (without changing the thrift code generator). This is documented in thrift_operators.cc. -- To view, visit http://gerrit.cloudera.org:8080/11693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1aacf602c603b05433c357a4a236ba0b9e521392 Gerrit-Change-Number: 11693 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Oct 2018 21:49:56 +0000 Gerrit-HasComments: Yes
