Hello Will Berkeley, Dan Burkert, Jean-Daniel Cryans,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11716

to review the following change.


Change subject: catalog_manager: adjust maximum tablet count at table creation 
time
......................................................................

catalog_manager: adjust maximum tablet count at table creation time

The maximum tablet check introduced in commit 64983c454 was incomplete in
that it only considered the number of _tablets_ rather than the number of
_replicas_, even though replica creation itself places load on a tserver
during table creation. This patch clarifies the intended behavior and
incorporates the replication factor of the table into the check.

Note: users who override --max_create_tablets_per_ts are in for a rude
surprise as the maximum size of their tables will be effectively cut in
three. Given that the parameter isn't tagged as "stable" though, I think
communicating this change in behavior via release note is sufficient.

Change-Id: I00d91baddb1591476a7be27cba043e6354558208
---
M docs/known_issues.adoc
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
3 files changed, 27 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11716/1
--
To view, visit http://gerrit.cloudera.org:8080/11716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00d91baddb1591476a7be27cba043e6354558208
Gerrit-Change-Number: 11716
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>

Reply via email to