Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11716 )
Change subject: catalog_manager: adjust maximum tablet count at table creation time ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11716/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11716/1/src/kudu/master/catalog_manager.cc@1503 PS1, Line 1503: // Verify that the number of replicas isn't larger than the number of live tablet : // servers. : if (FLAGS_catalog_manager_check_ts_count_for_create_table && num_replicas > num_live_tservers) { : // Note: this error message is matched against in master-stress-test. : return SetupError(Status::InvalidArgument(Substitute( : "not enough live tablet servers to create a table with the requested replication " : "factor $0; $1 tablet servers are alive", req.num_replicas(), num_live_tservers)), : resp, MasterErrorPB::REPLICATION_FACTOR_TOO_HIGH); : } > While you are at it, one usability nit. 'an attempt to create tablet with RF=3 ...' --> 'an attempt to create _table_ with RF=3 ...' -- To view, visit http://gerrit.cloudera.org:8080/11716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00d91baddb1591476a7be27cba043e6354558208 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 18 Oct 2018 02:35:11 +0000 Gerrit-HasComments: Yes
