Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 )
Change subject: [sentry] improve SentryAction ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11720/2/src/kudu/sentry/sentry_action.h File src/kudu/sentry/sentry_action.h: http://gerrit.cloudera.org:8080/#/c/11720/2/src/kudu/sentry/sentry_action.h@66 PS2, Line 66: static Status FromString(const std::string& str, Action* action); I don't understand the second parameter here; I would have expected it to be of type SentryAction, but without a default constructor you can't construct an "empty" SentryAction in which FromString can write the result. Is this useful in this form? http://gerrit.cloudera.org:8080/#/c/11720/2/src/kudu/sentry/sentry_action.h@77 PS2, Line 77: SentryAction() = delete; Why is this necessary? -- To view, visit http://gerrit.cloudera.org:8080/11720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc6c0fb2a33a24745936c96363390e776b24513f Gerrit-Change-Number: 11720 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Oct 2018 18:40:14 +0000 Gerrit-HasComments: Yes
