Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 )
Change subject: [sentry] improve SentryAction ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11720/4/src/kudu/sentry/sentry_action.h File src/kudu/sentry/sentry_action.h: http://gerrit.cloudera.org:8080/#/c/11720/4/src/kudu/sentry/sentry_action.h@36 PS4, Line 36: enum class Action { You can still make this nested inside SentryAction if you want; I don't think either ActionToString() or operator<< require it to be a stand-alone class. -- To view, visit http://gerrit.cloudera.org:8080/11720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc6c0fb2a33a24745936c96363390e776b24513f Gerrit-Change-Number: 11720 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 21:37:51 +0000 Gerrit-HasComments: Yes
