Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11720 )
Change subject: [sentry] improve SentryAction ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11720/3/src/kudu/sentry/sentry_action.h File src/kudu/sentry/sentry_action.h: http://gerrit.cloudera.org:8080/#/c/11720/3/src/kudu/sentry/sentry_action.h@48 PS3, Line 48: }; > Hmm, this was probably better as an enum class. Done -- To view, visit http://gerrit.cloudera.org:8080/11720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc6c0fb2a33a24745936c96363390e776b24513f Gerrit-Change-Number: 11720 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 20:59:52 +0000 Gerrit-HasComments: Yes
