Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py@46 PS1, Line 46: # Matches versions in the format of major.minor.patch-optional-label. > I name the subgroups because it's sort of self documenting the regex. That It does document the regex somewhat, but I also had to look up what (?P<...>) meant, as it was a syntax I was unfamiliar with. http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py@47 PS2, Line 47: SNAPShOT SNAPSHOT http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py@55 PS2, Line 55: (kudu_version, kudu_label) = parse_version_and_label() It's easy to miss this between the function and class definitions. Maybe move this to L110 or lower, and pass the results as arguments into the functions that need them? -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 17:27:31 +0000 Gerrit-HasComments: Yes
