Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11735/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11735/1//COMMIT_MSG@15 PS1, Line 15: to include updating the example project poms. > I think it is best if people just starting with Kudu use the latest version I removed this for now. http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py@46 PS1, Line 46: r"^(?P<version>(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+))(?:-(?P<label>.+))?", > It does document the regex somewhat, but I also had to look up what (?P<... Done http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py@47 PS2, Line 47: > SNAPSHOT Done http://gerrit.cloudera.org:8080/#/c/11735/2/python/setup.py@55 PS2, Line 55: (version, label) = parse_version_and_label() > It's easy to miss this between the function and class definitions. Maybe mo Done -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 17:38:12 +0000 Gerrit-HasComments: Yes
