Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11735 )
Change subject: [build] Centralize project version to version.txt ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py File python/setup.py: http://gerrit.cloudera.org:8080/#/c/11735/1/python/setup.py@44 PS1, Line 44: version_file = open(os.path.join(setup_dir, '../version.txt')).read() I thought we tried this initially but it doesn't work because of the way python source distributions work. The sdist is just a tarball of the python/ directory, without any ../version.txt, and so this would fail when trying to install from pypi -- To view, visit http://gerrit.cloudera.org:8080/11735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib654be8657ae3dc2f193056484b5d0743aa1ce95 Gerrit-Change-Number: 11735 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 17:56:38 +0000 Gerrit-HasComments: Yes
