Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11736 )
Change subject: Use preferred private client API method for a couple of tools functions ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h@459 PS1, Line 459: std::string GetMasterAddresses() const KUDU_NO_EXPORT; Maybe GetLeaderMasterAddresses() would be more precise? http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.cc@934 PS1, Line 934: // The strategy for retrieving the partitions from the metacache is adapted : // from KuduScanTokenBuilder::Data::Build. Can't unify this as per the feedback I left on the other patch? -- To view, visit http://gerrit.cloudera.org:8080/11736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bc5e59c9e8a77faa99ca0be11db19eb04dbcb9 Gerrit-Change-Number: 11736 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 17:46:50 +0000 Gerrit-HasComments: Yes
