Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11736 )
Change subject: Use preferred private client API method for a couple of tools functions ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h@459 PS1, Line 459: std::string GetMasterAddresses() const KUDU_NO_EXPORT; > That sounds like we are getting all the addresses of the leader master, not Oh, I see, I misunderstood the original meaning. Your other suggestion is pretty long. It's a private API, so let's just keep it as-is. -- To view, visit http://gerrit.cloudera.org:8080/11736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bc5e59c9e8a77faa99ca0be11db19eb04dbcb9 Gerrit-Change-Number: 11736 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 18:00:05 +0000 Gerrit-HasComments: Yes
