Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11736 )
Change subject: Use preferred private client API method for a couple of tools functions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11736/1/src/kudu/client/client.h@453 PS1, Line 453: as a CSV > I just went with the minimal change to what was already working. If you fee For the current use-cases it seems to be OK, but my concern is that usually API tend to be used in multiple contexts and various places. Using the CSV format doesn't seem universal enough. I don't feel strong against CSV here, but it looks a bit surprising. -- To view, visit http://gerrit.cloudera.org:8080/11736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5bc5e59c9e8a77faa99ca0be11db19eb04dbcb9 Gerrit-Change-Number: 11736 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 18:57:39 +0000 Gerrit-HasComments: Yes
