Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11737 )
Change subject: De-flake ASAN TestSimultaneousLeaderTransferAndAbruptStepdown ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc@1495 PS1, Line 1495: every second > nit: this is not the case for ASAN now. Done http://gerrit.cloudera.org:8080/#/c/11737/1/src/kudu/tools/kudu-admin-test.cc@1511 PS1, Line 1511: SleepFor(leader_change_period); > Just a thought about making it more stable (just in case of this fix is not Good idea. Testing with dist-test indicated this fix is enough, but I will keep your suggestion in mind if the test becomes flaky again somehow. -- To view, visit http://gerrit.cloudera.org:8080/11737 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3237f3fde48daeb2f307dfb78d457217df2beed Gerrit-Change-Number: 11737 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 22 Oct 2018 21:03:11 +0000 Gerrit-HasComments: Yes
