Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11727/2/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/2/src/kudu/integration-tests/table_locations-itest.cc@315 PS2, Line 315: : { // Check that the master doesn't give back partial results while the table is being created. : GetTableLocationsRequestPB req; : GetTableLocationsResponsePB resp; : RpcController controller; : req.mutable_table()->set_table_name(table_name); : : for (int i = 1; ; i++) { : if (i > 10) { : FAIL() << "Create table timed out"; : } : : controller.Reset(); : ASSERT_OK(proxy_->GetTableLocations(req, &resp, &controller)); : SCOPED_TRACE(SecureDebugString(resp)); : : if (resp.has_error()) { : ASSERT_EQ(MasterErrorPB::TABLET_NOT_RUNNING, resp.error().code()); : SleepFor(MonoDelta::FromMilliseconds(i * i * 100)); : } else { : ASSERT_EQ(1, resp.tablet_locations().size()); : break; : } : } : } > This is same as the one above. Seems like if I don't add it, some errors wi OK, then please encapsulate it into a common helper method. And maybe combine it into CreateTable() if they're always called one after the other. -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 2 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 22 Oct 2018 21:26:41 +0000 Gerrit-HasComments: Yes
