Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: EXPECT_EQ("", resp.tablet_locations(0).replicas(0).ts_info().location()); nit: could you add ASSERT_EQ() on the expected number of locations returned in the response before trying to access the very first one by resp.tablet_locations(0)? Similar ASSERT_EQ() for replicas() within each location. http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@317 PS5, Line 317: replicas(0) nit: how many replicas do you expect to be returned in the response? If multiple, I think it's worth verifying that ts_info for every replica has the expected location. -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 5 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Oct 2018 22:18:14 +0000 Gerrit-HasComments: Yes
