Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11727 )
Change subject: [location_awareness] Add ts location to TSInfoPB ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/11727/3/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/3/src/kudu/integration-tests/table_locations-itest.cc@104 PS3, Line 104: > warning: parameter 'tablet_locations_size' is const-qualified in > the function declaration; const-qualification of parameters only > has an effect in function definitions > [readability-avoid-const-params-in-decls] > void CheckMasterTableCreation(const string &table_name, const int > tablet_locations_size); > ^~~~~~~~~~ http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc File src/kudu/integration-tests/table_locations-itest.cc: http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@74 PS5, Line 74: > Add a call to SetUpConfig() here. Then you won't need to override SetUp() i Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@216 PS5, Line 216: } > You need to surround these calls with NO_FATALS(); otherwise, errors in Che Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: GetTableLocationsResponsePB resp; > nit: could you add ASSERT_EQ() on the expected number of locations returned Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@294 PS5, Line 294: GetTableLocationsResponsePB resp; : RpcController controller; : req.mutable_table()->set_table_name(table_name); > Nit: do this in a loop. Done http://gerrit.cloudera.org:8080/#/c/11727/5/src/kudu/integration-tests/table_locations-itest.cc@317 PS5, Line 317: > nit: how many replicas do you expect to be returned in the response? If mu Done -- To view, visit http://gerrit.cloudera.org:8080/11727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5865cb47698817097a7f62c968c5cfd80e07259 Gerrit-Change-Number: 11727 Gerrit-PatchSet: 6 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 25 Oct 2018 01:17:10 +0000 Gerrit-HasComments: Yes
