Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 )
Change subject: WIP KUDU-2542: add initial authorization token impl ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h File src/kudu/security/token_signer.h: http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@84 PS1, Line 84: tsk_propagation_period I don't quite follow the need to add this sentence. Is this a term mentioned/defined in other places? Do you mean 'tsk_propagation_interval'? http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@124 PS1, Line 124: Note that the Activity Interval is identically the rotation : // interval I am not sure why is that necessary? http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@211 PS1, Line 211: max(authn_token_validity, authz_token_validity) I know there is a lot of detailed description of why we end it up with this equation but maybe add a few sentences to concisely state the reason again, so that readers are not lost in the details? http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token_signer.h@289 PS1, Line 289: GenerateAuthzToken nit: add a comment? -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Oct 2018 18:10:12 +0000 Gerrit-HasComments: Yes
