Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 )
Change subject: WIP KUDU-2542: add initial authorization token impl ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto File src/kudu/security/token.proto: http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@49 PS1, Line 49: optional bool update_privilege = 5; We don't support authz on per-column basis for update, right? http://gerrit.cloudera.org:8080/#/c/11750/1/src/kudu/security/token.proto@64 PS1, Line 64: optional > I think it is one table per AuthzToken. Add a comment here to clarify that? That was a generic question regarding current authz token design and whether it's about to evolve in the future. I understand that current implementation assumes a single table privilege per token. The question is whether it's anticipated to change in the future, and if yes, how we are about to expand this message. Probably, it's not worth thinking about that now, and if needed, we can always update the message and introduce new fields and obsolete old ones when it's needed. -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Oct 2018 22:24:57 +0000 Gerrit-HasComments: Yes
